Implement streaming for specialized group by string aggregator #9188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
github-actions
bot
added
physical-expr
…mn string grouping compiles. add test for null
alamb
force-pushed
the
alamb/specialized_group_keys_with_streaming
branch
from
da68c45 to
489c4c1
Compare
alamb
changed the title
alamb
commented
Feb 11, 2024
| } | ||
| } | ||
|
|
||
| /// Removes the first n distinct values inserted into this set, in the order |
There was a problem hiding this comment.
This is the code that removes only the first_n from the set and updates the state. It is pretty complicated and I am not sure the performance benefit is worth it
There was a problem hiding this comment.
It does have significant test coverage, however
|
This thing is crazy complicated -- I don't plan to pursue it unless there is a real need to improve this performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a snapshot of the code for #8827
Related to #9195
This PR includes support for
emit_towhich I am confident is correct but is quite complicated and I didn't want to include in the first version