Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](statistics)Fix replace table doesn't remove table stat meta memory leak bug. #49345 #49357

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #49345

…ory leak bug. (#49345)

Fix replace table doesn't remove table stat meta bug. When doing replace
table with property swap=false, the old table is removed. In this case,
we need to remove the table stats meta object for that table to avoid
memory leak.
@github-actions github-actions bot requested a review from dataroaring as a code owner March 22, 2025 03:13
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 22, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39868 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03ffa4c3a69b20d3fabbe079512ceb7c7be69229, data reload: false

------ Round 1 ----------------------------------
q1	17570	6942	6567	6567
q2	2071	172	165	165
q3	10613	1083	1141	1083
q4	10568	734	761	734
q5	7776	2843	2780	2780
q6	216	135	130	130
q7	987	605	603	603
q8	9340	1911	2054	1911
q9	6583	6398	6408	6398
q10	7012	2205	2287	2205
q11	463	260	264	260
q12	404	210	204	204
q13	17785	3006	3018	3006
q14	242	214	205	205
q15	490	469	462	462
q16	644	586	584	584
q17	959	631	509	509
q18	7232	6771	6688	6688
q19	1394	1093	1049	1049
q20	478	200	196	196
q21	4034	3156	3169	3156
q22	1079	1005	973	973
Total cold run time: 107940 ms
Total hot run time: 39868 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6625	6586	6544	6544
q2	330	242	238	238
q3	2944	2764	2943	2764
q4	2036	1762	1748	1748
q5	5825	5756	5754	5754
q6	205	124	131	124
q7	2210	1875	1806	1806
q8	3399	3545	3523	3523
q9	8691	8994	8840	8840
q10	3580	3540	3523	3523
q11	596	481	506	481
q12	807	631	583	583
q13	7836	3205	3194	3194
q14	318	275	277	275
q15	504	473	471	471
q16	684	669	649	649
q17	1856	1614	1641	1614
q18	8182	7742	7580	7580
q19	1644	1500	1645	1500
q20	2108	1907	1882	1882
q21	5674	5553	5249	5249
q22	1156	1035	1047	1035
Total cold run time: 67210 ms
Total hot run time: 59377 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197593 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 03ffa4c3a69b20d3fabbe079512ceb7c7be69229, data reload: false

query1	1278	921	921	921
query2	6225	2071	1982	1982
query3	10822	4193	4268	4193
query4	65792	28216	23646	23646
query5	4996	446	436	436
query6	411	183	188	183
query7	5575	311	312	311
query8	312	224	225	224
query9	8894	2634	2633	2633
query10	457	259	262	259
query11	17484	15478	15715	15478
query12	156	106	103	103
query13	1481	434	471	434
query14	10909	7478	7683	7478
query15	200	183	185	183
query16	7094	484	493	484
query17	1115	597	607	597
query18	1913	319	337	319
query19	224	165	161	161
query20	120	114	106	106
query21	199	110	113	110
query22	4849	4404	4237	4237
query23	34656	34003	33945	33945
query24	6288	2923	2947	2923
query25	536	433	433	433
query26	680	176	171	171
query27	2235	352	355	352
query28	4490	2474	2440	2440
query29	731	487	480	480
query30	245	164	161	161
query31	984	830	827	827
query32	67	52	56	52
query33	432	301	296	296
query34	934	518	523	518
query35	898	760	730	730
query36	1109	974	968	968
query37	116	69	68	68
query38	4036	4020	3946	3946
query39	1503	1484	1447	1447
query40	197	107	101	101
query41	49	50	50	50
query42	116	102	122	102
query43	532	493	505	493
query44	1192	836	847	836
query45	182	172	178	172
query46	1133	736	726	726
query47	2042	1932	1967	1932
query48	471	387	385	385
query49	720	392	390	390
query50	847	432	434	432
query51	7370	7221	7005	7005
query52	95	88	85	85
query53	261	184	176	176
query54	555	456	449	449
query55	76	76	74	74
query56	267	224	234	224
query57	1258	1122	1109	1109
query58	214	204	219	204
query59	3026	2841	2813	2813
query60	270	260	247	247
query61	133	108	107	107
query62	770	674	695	674
query63	221	191	199	191
query64	1348	662	630	630
query65	3236	3191	3180	3180
query66	704	301	301	301
query67	15848	15617	15678	15617
query68	4114	591	577	577
query69	429	264	261	261
query70	1204	1151	1134	1134
query71	364	255	258	255
query72	6385	4070	4003	4003
query73	746	352	347	347
query74	10189	8913	9392	8913
query75	3342	2685	2651	2651
query76	1873	1113	1153	1113
query77	506	271	280	271
query78	10435	9605	9636	9605
query79	1661	598	607	598
query80	1112	432	426	426
query81	526	241	248	241
query82	189	90	84	84
query83	158	149	141	141
query84	283	81	80	80
query85	971	308	284	284
query86	402	300	292	292
query87	4499	4336	4400	4336
query88	4090	2413	2368	2368
query89	416	302	298	298
query90	1978	184	183	183
query91	182	146	147	146
query92	66	52	47	47
query93	2367	555	542	542
query94	839	295	294	294
query95	360	253	258	253
query96	634	278	290	278
query97	3357	3120	3148	3120
query98	214	203	196	196
query99	1585	1316	1317	1316
Total cold run time: 319055 ms
Total hot run time: 197593 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.88 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03ffa4c3a69b20d3fabbe079512ceb7c7be69229, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.10
query5	0.54	0.49	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.49
query10	0.53	0.54	0.54
query11	0.15	0.11	0.10
query12	0.14	0.12	0.11
query13	0.61	0.59	0.59
query14	2.85	2.84	2.86
query15	0.89	0.82	0.82
query16	0.39	0.38	0.38
query17	1.06	1.06	1.04
query18	0.23	0.21	0.22
query19	1.96	1.75	2.01
query20	0.01	0.01	0.02
query21	15.35	0.56	0.59
query22	2.41	2.43	1.77
query23	17.07	0.92	0.90
query24	3.03	1.60	1.95
query25	0.19	0.14	0.12
query26	0.43	0.14	0.14
query27	0.05	0.04	0.05
query28	9.03	0.55	0.51
query29	12.61	3.32	3.31
query30	0.24	0.06	0.06
query31	2.86	0.39	0.38
query32	3.25	0.46	0.47
query33	2.95	2.98	3.02
query34	17.12	4.45	4.46
query35	4.54	4.50	4.49
query36	0.65	0.48	0.48
query37	0.09	0.06	0.05
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.34 s
Total hot run time: 32.88 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8fccc99 into branch-3.0 Mar 24, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49345-branch-3.0 branch March 24, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants