Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [opt](s3client) Set ClientConfiguration.requestTimeoutMs default value from 3000ms to 30000ms #49315 #49363

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #49315

…e from 3000ms to 30000ms (#49315)

* ClientConfiguration.requestTimeoutMs default is 3000ms in
`aws-sdk-cpp`, this should be more than adequate for most services.
However, we meet problem when cloud provider's storage service or
network not stable

* refer to
https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h
@github-actions github-actions bot requested a review from dataroaring as a code owner March 22, 2025 07:40
@Thearas
Copy link
Contributor

Thearas commented Mar 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 22, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 22, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39807 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9e3a1e36f9880bd9a62094dadd895f31912d1a4, data reload: false

------ Round 1 ----------------------------------
q1	17624	6739	6587	6587
q2	2071	168	187	168
q3	10703	1061	1199	1061
q4	10541	705	769	705
q5	7755	2834	2807	2807
q6	223	135	130	130
q7	987	617	602	602
q8	9361	1934	2014	1934
q9	6608	6401	6361	6361
q10	7034	2273	2334	2273
q11	462	255	255	255
q12	391	211	211	211
q13	17780	2990	2993	2990
q14	233	206	211	206
q15	507	467	457	457
q16	674	581	593	581
q17	964	628	541	541
q18	7294	6667	6525	6525
q19	1410	1126	1132	1126
q20	480	207	201	201
q21	3989	3104	3292	3104
q22	1095	998	982	982
Total cold run time: 108186 ms
Total hot run time: 39807 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6642	6550	6547	6547
q2	328	228	227	227
q3	2890	2765	2933	2765
q4	2038	1814	1787	1787
q5	5752	5797	5728	5728
q6	215	128	129	128
q7	2268	1799	1798	1798
q8	3493	3623	3588	3588
q9	8897	8997	9009	8997
q10	3620	3489	3550	3489
q11	584	501	488	488
q12	788	583	597	583
q13	7938	3230	3168	3168
q14	301	280	278	278
q15	514	486	450	450
q16	683	641	664	641
q17	1842	1618	1604	1604
q18	8236	7779	7665	7665
q19	1672	1607	1611	1607
q20	2112	1851	1916	1851
q21	5548	5350	5316	5316
q22	1085	1006	1030	1006
Total cold run time: 67446 ms
Total hot run time: 59711 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10170/26157)
Line Coverage 30.30% (86743/286270)
Region Coverage 29.35% (44566/151848)
Branch Coverage 25.87% (22669/87618)

@doris-robot
Copy link

TPC-DS: Total hot run time: 197217 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9e3a1e36f9880bd9a62094dadd895f31912d1a4, data reload: false

query1	1315	895	899	895
query2	6255	2080	2033	2033
query3	10829	4276	4240	4240
query4	65833	29202	23231	23231
query5	5072	467	459	459
query6	413	181	182	181
query7	5762	316	305	305
query8	314	229	231	229
query9	9433	2623	2625	2623
query10	457	274	249	249
query11	17879	15102	15780	15102
query12	153	101	103	101
query13	1514	430	422	422
query14	10722	7645	7150	7150
query15	206	177	182	177
query16	7067	486	485	485
query17	1052	569	558	558
query18	1888	307	307	307
query19	222	170	159	159
query20	123	109	107	107
query21	209	101	101	101
query22	4829	4689	4493	4493
query23	34239	33993	33970	33970
query24	6135	2888	2893	2888
query25	552	452	438	438
query26	662	166	165	165
query27	1940	359	358	358
query28	4339	2501	2462	2462
query29	715	467	477	467
query30	249	168	175	168
query31	1054	809	822	809
query32	62	54	54	54
query33	439	307	311	307
query34	914	510	532	510
query35	867	722	731	722
query36	1086	981	964	964
query37	117	68	70	68
query38	4089	4052	4002	4002
query39	1506	1463	1661	1463
query40	214	97	97	97
query41	49	46	48	46
query42	110	101	106	101
query43	531	483	488	483
query44	1187	839	841	839
query45	187	174	166	166
query46	1155	730	735	730
query47	2039	1979	1958	1958
query48	488	383	402	383
query49	748	394	401	394
query50	861	439	440	439
query51	7492	7208	7290	7208
query52	98	92	100	92
query53	247	178	178	178
query54	563	445	462	445
query55	75	76	75	75
query56	255	236	226	226
query57	1233	1135	1120	1120
query58	208	200	204	200
query59	3102	3058	2924	2924
query60	292	252	254	252
query61	124	111	104	104
query62	756	671	648	648
query63	212	184	186	184
query64	1375	669	664	664
query65	3276	3203	3191	3191
query66	695	298	306	298
query67	16010	15647	15605	15605
query68	3592	584	602	584
query69	436	273	258	258
query70	1109	1162	1117	1117
query71	355	267	258	258
query72	6179	4209	4096	4096
query73	743	356	360	356
query74	10038	9158	9055	9055
query75	3376	2653	2673	2653
query76	1903	1064	1167	1064
query77	495	282	277	277
query78	10466	9507	9596	9507
query79	1697	604	595	595
query80	1227	422	415	415
query81	533	243	240	240
query82	1232	92	83	83
query83	269	144	142	142
query84	283	83	79	79
query85	1010	320	305	305
query86	426	274	307	274
query87	4426	4319	4345	4319
query88	3901	2407	2379	2379
query89	423	294	288	288
query90	1962	187	190	187
query91	182	150	152	150
query92	71	50	51	50
query93	1935	560	554	554
query94	836	294	292	292
query95	362	253	260	253
query96	615	281	282	281
query97	3324	3139	3187	3139
query98	215	198	202	198
query99	1603	1323	1297	1297
Total cold run time: 319318 ms
Total hot run time: 197217 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.12 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a9e3a1e36f9880bd9a62094dadd895f31912d1a4, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.04
query3	0.23	0.07	0.06
query4	1.63	0.11	0.10
query5	0.52	0.51	0.51
query6	1.14	0.74	0.72
query7	0.03	0.02	0.02
query8	0.03	0.03	0.03
query9	0.56	0.51	0.50
query10	0.55	0.55	0.54
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.73	2.76	2.85
query15	0.89	0.83	0.83
query16	0.38	0.39	0.38
query17	1.06	1.07	1.04
query18	0.24	0.23	0.22
query19	1.84	1.80	2.05
query20	0.01	0.02	0.01
query21	15.35	0.60	0.58
query22	2.91	1.76	1.94
query23	17.23	0.90	0.80
query24	3.01	1.86	0.87
query25	0.18	0.16	0.12
query26	0.41	0.14	0.13
query27	0.05	0.03	0.04
query28	9.83	0.52	0.50
query29	12.58	3.30	3.30
query30	0.25	0.06	0.06
query31	2.86	0.38	0.38
query32	3.24	0.46	0.45
query33	2.98	2.98	3.02
query34	17.20	4.48	4.45
query35	4.52	4.55	4.59
query36	0.68	0.48	0.48
query37	0.10	0.07	0.06
query38	0.06	0.03	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 106.65 s
Total hot run time: 32.12 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8beca26 into branch-3.0 Mar 24, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49315-branch-3.0 branch March 24, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants