Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Java 8 #17466

Merged
merged 62 commits into from
Nov 21, 2024
Merged

Remove support for Java 8 #17466

merged 62 commits into from
Nov 21, 2024

Conversation

Akshat-Jain
Copy link
Contributor

@Akshat-Jain Akshat-Jain commented Nov 11, 2024

Description

Starting with Apache Druid 32.0.0, we want to remove the support for Java 8. This PR does that as follows:

  • All JDK 8 based CI checks have been removed.
  • Images used in Dockerfile(s) have been updated to Java 17 based images.
  • Documentation has been updated accordingly.

Release note

Starting with Apache Druid 32.0.0, support for Java 8 has been removed.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@Akshat-Jain Akshat-Jain marked this pull request as ready for review November 11, 2024 04:23
@github-actions github-actions bot added the GHA label Nov 11, 2024
@Akshat-Jain Akshat-Jain changed the title [WIP] Deprecate Java 8 Deprecate Java 8 Nov 13, 2024
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making this move!

couple things I was thinking about while I've reviewed these changes:

  • upgrade apache parent pom to something which is more recent
  • remove specific versions from build plugins (let the parent do it)
  • finally we could upgrade the git-commit-id-plugin to a more recent version; it adds around 2 minutes to the project's sequential build time
  • possibly remove the elephantbird from the twitter plugin

+1 thank you @Akshat-Jain !

@clintropolis
Copy link
Member

clintropolis commented Nov 21, 2024

it looks like java 17 is still running in the second phase of unit tests, these can be removed i think since they replaced the java 8 tests in phase 1, https://github.com/apache/druid/blob/master/.github/workflows/unit-and-integration-tests-unified.yml#L165 (i think this should just be 11 and 21 now)

@Akshat-Jain
Copy link
Contributor Author

@clintropolis Makes sense, have made the change.

@cryptoe cryptoe merged commit 17215cd into apache:master Nov 21, 2024
83 checks passed
@Akshat-Jain Akshat-Jain mentioned this pull request Nov 25, 2024
9 tasks
kgyrtkirk pushed a commit that referenced this pull request Nov 26, 2024
We have removed support for Java 8 in #17466. This PR removes an unused profile pre-java-11 which activated for JDK < 11.
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants