-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Java 8 #17466
Remove support for Java 8 #17466
Conversation
…dated java version
…oogle.inject.extensions:guice-multibindings:jar:4.2.2:compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for making this move!
couple things I was thinking about while I've reviewed these changes:
- upgrade apache parent pom to something which is more recent
- remove specific versions from build plugins (let the parent do it)
- finally we could upgrade the git-commit-id-plugin to a more recent version; it adds around 2 minutes to the project's sequential build time
- possibly remove the elephantbird from the twitter plugin
+1 thank you @Akshat-Jain !
it looks like java 17 is still running in the second phase of unit tests, these can be removed i think since they replaced the java 8 tests in phase 1, https://github.com/apache/druid/blob/master/.github/workflows/unit-and-integration-tests-unified.yml#L165 (i think this should just be 11 and 21 now) |
@clintropolis Makes sense, have made the change. |
We have removed support for Java 8 in #17466. This PR removes an unused profile pre-java-11 which activated for JDK < 11.
Description
Starting with Apache Druid 32.0.0, we want to remove the support for Java 8. This PR does that as follows:
Release note
Starting with Apache Druid 32.0.0, support for Java 8 has been removed.
This PR has: