Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluent logger to simplify logging #14484

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Add fluent logger to simplify logging #14484

merged 2 commits into from
Aug 20, 2024

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Jul 31, 2024

What is the purpose of the change

The original ErrorTypeAwareLogger doesn't support string formatting, and cause, extendedInformation are absolutely mostly empty, so adding fluent wrappers to simplify the logging.
Meanwhile, we need modify the exception code inspect next step.

// Before:
    LOGGER.warn(
            PROTOCOL_FAILED_PARSE,
            "",
            "",
            String.format(
                    "Failed to parse request timeout set from:%s, service=%s " + "method=%s",
                    timeoutString, context.getServiceDescriptor().getInterfaceName(), context.getMethodName()));

// After
    LOGGER.warn(
            LoggerCodeConstants.PROTOCOL_FAILED_PARSE,
            "Failed to parse request timeout set from: {}, service={}, method={}",
            timeoutString,
            context.getServiceDescriptor().getInterfaceName(),
            context.getMethodName());

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean force-pushed the fluet-log branch 2 times, most recently from 5f44cb6 to c200df6 Compare August 9, 2024 04:54
Copy link

@AlbumenJ AlbumenJ merged commit 737ff1d into apache:3.3 Aug 20, 2024
19 checks passed
@oxsean oxsean deleted the fluet-log branch September 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants