-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support users to customize JsonUtil #14508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't entirely agree with this JsonUtilCustomizer.
It increases the complexity of jsonutil and allows users to re-implement jsonutil if they want to customize some parameters
It's really something we need to consider, This feature is for rest, the complexity is relative, for the end user to use |
1db050a
to
04f5cf9
Compare
...ting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpJsonUtils.java
Outdated
Show resolved
Hide resolved
2c10886
to
4592d69
Compare
3021f48
to
e95b411
Compare
e95b411
to
e3a9fb4
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #14508 +/- ##
==========================================
+ Coverage 38.05% 38.06% +0.01%
==========================================
Files 1804 1805 +1
Lines 80043 80094 +51
Branches 11898 11906 +8
==========================================
+ Hits 30461 30491 +30
- Misses 45190 45215 +25
+ Partials 4392 4388 -4 ☔ View full report in Codecov by Sentry. |
@oxsean The pr title could be changed. |
@chickenlj PTAL |
# Conflicts: # dubbo-remoting/dubbo-remoting-http12/src/test/java/org/apache/dubbo/remoting/http12/message/codec/CodeUtilsTest.java # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/CompositeExceptionHandler.java
1192f20
to
27dd643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
In http scenario, the user wants to customize the JSON conversion.
Brief changelog
Verifying this change
Checklist