-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][ISSUE #4426] Optimize EventMesh Bridge with QUIC #4427
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yixiang Zhao <[email protected]>
Signed-off-by: Yixiang Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seriouszyx Please fix code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag for the title of this PR has always been WIP, so is this PR still under development?
@@ -271,6 +272,9 @@ private void registerHTTPRequestProcessor() throws Exception { | |||
final LocalSubscribeEventProcessor localSubscribeEventProcessor = new LocalSubscribeEventProcessor(this); | |||
this.getHandlerService().register(localSubscribeEventProcessor, clientManageExecutor); | |||
|
|||
final QuicLocalSubscribeEventProcessor quicLocalSubscribeEventProcessor = new QuicLocalSubscribeEventProcessor(this); | |||
this.getHandlerService().register(quicLocalSubscribeEventProcessor, clientManageExecutor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this QUIC protocol be made configurable? If not configured, it will be enabled or disabled by default.
可不可以把 QUIC 协议的方式做成可配置的?不配置话的就默认开启或不开启。
Channel channel = bs.group(group) | ||
.channel(NioDatagramChannel.class) | ||
.handler(codec) | ||
.bind(new InetSocketAddress(9999)).sync().channel(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the port of this protocol be made configurable?
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Any progress we can make here? |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #4426.