Do not print an error when a wildcard is used in component header #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwatson
reviewed
Feb 21, 2025
scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java
Show resolved
Hide resolved
Currently SCR prints an error if one uses a wildcard in the header but nothing matches. But because fragemnts are not allowed to provide an own header, only the host can enable this. So this now adds an additional check before logging an error that prevents an error from being printed if a wildcard is provided and prints a trace message instead.
laeubi
force-pushed
the
do_not_print_an_error_if_wildcard_is_used
branch
from
39619a9 to
6b4de07
Compare
tjwatson
approved these changes
Feb 21, 2025
|
@tjwatson @stbischof can this be merged? |
|
What i the benefit? We log an error before. Now we also trace the same information additional. Isnt that just Duplikat? |
|
Please notice this line in the PR: so before it always printed an error, now it only prints error if not a wildcard (but a trace message instead). |
Now that @stbischof made the comment. I think the code could be more clear with the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SCR prints an error if one uses a wildcard in the header but nothing matches. But because fragemnts are not allowed to provide an own header, only the host can enable this.
So this now adds an additional check before logging an error that prevents an error from being printed if a wildcard is provided.
See