Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader #25679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Nov 22, 2024

What is the purpose of the change

See reasoning in FLINK-36451 comment

Brief change log

  • Adds runAsLeader method that executes callbacks on the leadership main thread
  • Replaces hasLeadership calls with runAsLeader

Verifying this change

  • Adds unit tests
  • Rewrites hasLeadership tests in unit test classes

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 22, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants