[FLIP-481][FLINK-37426] Introduce Event Reporting #26316
+3,970
−1,051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...link-metrics-otel/src/main/java/org/apache/flink/events/otel/OpenTelemetryEventReporter.java
Show resolved
Hide resolved
…and implementations.
davidradl
reviewed
Mar 19, 2025
| <td><h5>events.reporter.<name>.filter.includes</h5></td> | ||
| <td style="word-wrap: break-word;">"*:*:*"</td> | ||
| <td>List<String></td> | ||
| <td>The events that should be included for the reporter named <name>. Filters are specified as a list, with each filter following this format:<br /><code class="highlighter-rouge"><scope>[:<name>[,<name>]]</code><br />An event matches a filter if the scope pattern and at least one of the name patterns match.<br /><ul><li>scope: Filters based on the logical scope.<br />Specified as a pattern where <code class="highlighter-rouge">*</code> matches any sequence of characters and <code class="highlighter-rouge">.</code> separates scope components.<br /><br />For example:<br /> "<code class="highlighter-rouge">jobmanager.job</code>" matches any job-related events on the JobManager,<br /> "<code class="highlighter-rouge">*.job</code>" matches all job-related events and<br /> "<code class="highlighter-rouge">*.job.*</code>" matches all events below the job-level (i.e., task/operator events etc.).<br /><br /></li><li>name: Filters based on the event name.<br />Specified as a comma-separate list of patterns where <code class="highlighter-rouge">*</code> matches any sequence of characters.<br /><br />For example, "<code class="highlighter-rouge">*Records*,*Bytes*</code>" matches any event where the name contains <code class="highlighter-rouge">"Records" or "Bytes"</code>.</li></ul></td> |
There was a problem hiding this comment.
nit: comma-separate -> comma separated
davidradl
suggested changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
https://cwiki.apache.org/confluence/display/FLINK/FLIP-481%3A+Introduce+Event+Reporting
Brief change log
Please check the individual commit mesages.
Verifying this change
Refactoring is covered by the existing tests. For Events reporting this adds bunch of new tests, including an ITCase integrating with Otel container.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation