[FLINK-37511][rest] Use Jackson serialization in JobPlanInfo.Plan #26320
+933
−181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The pr follows refactors done over time to transition rest object classes to use modern auto-serialization instead of implementing their own serializations.
Doing the same for
org.apache.flink.runtime.rest.messages.JobPlanInfo.Plan
improves error handling and makes the restAPI more informative about expected response.Brief change log
org.apache.flink.runtime.rest.messages.JobPlanInfo.Plan
type refactored to object instead of a stringVerifying this change
This change is already covered by existing tests, such as (please describe tests).
org.apache.flink.runtime.jobgraph.jsonplan.JsonGeneratorTest#testGeneratorWithoutAnyAttachements
org.apache.flink.runtime.rest.messages.JobPlanInfoTest#testJsonMarshalling
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation
Open questions / follow ups
To be able to completely get rid of
org.apache.flink.runtime.rest.messages.JobPlanInfo.RawJson#RawJson
I would need to refactor StreamGraphs as well - Should probably separate it to a follow up PR to reduce blast radius? cc @zentol