[FLINK-37525] Introduce a overload findModuleFactory to improve the performance of installModules #26329
+79
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aim to improve the performance of
installModules
by introduce an overloadfindModuleFactory
.Currently, the implementation of
installModules
has the logic show below.The implementation of
findModuleFactory
show below.You can see no matter what the
securityModuleFactoryClass
is, theSecurityModuleFactory.class
andSecurityModuleFactory.class.getClassLoader()
are certain.The implementation of
findFactoryInternal
show below.You can see
findFactoryInternal
loadServiceLoader
and match theclassFactory
.These code lead to repeatedly loading
ServiceLoader
and match theclassFactory
.Brief change log
Introduce a overload
findModuleFactory
to improve the performance ofinstallModules
Verifying this change
This change is already covered by existing tests, such as (
TestingSecurityContext
).Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation