[FLINK-37665]: Simplify DoubleMaximum.clone() Implementation #26449
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The purpose of this change is to simplify the implementation of the clone() method in the DoubleMaximum class by leveraging the existing constructor DoubleMaximum(double value) instead of manually setting the max field
Brief change log:
The current implementation of the clone() method in the DoubleMaximum class uses the default constructor and manually sets the max field:
// Some comments here
@OverRide
public DoubleMaximum clone() {
DoubleMaximum clone = new DoubleMaximum();
clone.max = this.max;
return clone;
}
This can be simplified by directly using the existing constructor DoubleMaximum(double value) to initialize the cloned object. The proposed change is:
@OverRide
public DoubleMaximum clone() {
return new DoubleMaximum(this.max);
}
Verifying this change:
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: no
The S3 file system connector: no
Documentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable