Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): set compressString default value to false #1913

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

chaokunyang
Copy link
Collaborator

What does this PR do?

set compressString default value to false

Related issues

#1890

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@zhaommmmomo
Copy link
Member

This code needs to be updated

@chaokunyang
Copy link
Collaborator Author

chaokunyang commented Nov 5, 2024

This code needs to be updated

@zhaommmmomo Should be OK now.

@chaokunyang chaokunyang force-pushed the fix_compressed_flag_doc branch from 59d7ba1 to ef3cfb1 Compare November 5, 2024 13:46
@zhaommmmomo zhaommmmomo enabled auto-merge (squash) November 5, 2024 14:33
@zhaommmmomo zhaommmmomo disabled auto-merge November 5, 2024 14:33
Copy link
Member

@zhaommmmomo zhaommmmomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaommmmomo zhaommmmomo merged commit 5eafb12 into apache:main Nov 5, 2024
3 checks passed
chaokunyang added a commit that referenced this pull request Feb 7, 2025
## What does this PR do?

set compressString default value to false
## Related issues
#1890 

## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants