fix(java): fix find constructor error in generated serializer class caused by duplicated class classloading for Fury #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
changed the title
HuangXingBo
approved these changes
Nov 21, 2024
chaokunyang
changed the title
theweipeng
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix duplicate classloading in parent classloader.
Some classloader such as flink classloader can load class from children classloader. If fury is located in children classloader, but we are serializing a class in such parent class, the parent class will load Fury class again, which caused two Fury clases loaded.
Related issues
Closes #1947
Does this PR introduce any user-facing change?
Benchmark