Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1290: Add support for ssh certificate Authentication #450

Conversation

Tejaswikandula
Copy link
Contributor

No description provided.

@necouchman
Copy link
Contributor

@Tejaswikandula : Your pull request and commit messages need to have the GUACAMOLE-1290: prefix.

@Tejaswikandula Tejaswikandula changed the title Add support for ssh certificate Authentication GUACAMOLE-1290: Add support for ssh certificate Authentication Jun 29, 2023
@Tejaswikandula
Copy link
Contributor Author

@Tejaswikandula : Your pull request and commit messages need to have the GUACAMOLE-1290: prefix.

Edited the commit message

@Tejaswikandula Tejaswikandula force-pushed the GUACAMOLE-1290_add-support-for-ssh-certificates branch from 8cd09ab to ba326ae Compare June 29, 2023 16:47
@Tejaswikandula Tejaswikandula force-pushed the GUACAMOLE-1290_add-support-for-ssh-certificates branch from ba326ae to f2b9aaf Compare June 29, 2023 16:48
Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good - two minor things to clean up, and I think it will be ready to merge.

src/common-ssh/common-ssh/user.h Show resolved Hide resolved
src/protocols/ssh/settings.h Outdated Show resolved Hide resolved
@necouchman necouchman merged commit 80598ae into apache:master Aug 1, 2023
@necouchman
Copy link
Contributor

Thanks @Tejaswikandula - could you also add the documentation to apache/guacamole-manual and do a pull request for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants