GUACAMOLE-1996: Adding Dvorak ES keyboard layout #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tetebueno : Thank you for contributing to this. The changes themselves look good, but you'll need to sign up for a Jira account and create a Jira issue for this change, and then tag the PR and the commit messages with the Jira issue (see other PRs for examples). |
tetebueno
changed the title
|
Just generated the following issue: https://issues.apache.org/jira/projects/GUACAMOLE/issues/GUACAMOLE-1996?filter=allopenissues |
necouchman
reviewed
Oct 24, 2024
| @@ -233,6 +233,7 @@ rdp_keymaps = \ | |||
| $(srcdir)/keymaps/en_gb_qwerty.keymap \ | |||
| $(srcdir)/keymaps/en_us_qwerty.keymap \ | |||
| $(srcdir)/keymaps/es_es_qwerty.keymap \ | |||
| $(srcdir)/keymaps/es_es_dvorak.keymap \ | |||
There was a problem hiding this comment.
As with the client-side changes, the es_es_dvorak entry should go above the es_es_qwerty entry...
There was a problem hiding this comment.
Done. I'll be checking build failure.
|
Hey there, build is fixed (at least locally). Let me know if there's anything else I can help with. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Spanish Dvorak keyboard layout included in Ubuntu distributions.