Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8498] Fix the async compaction task configuration error in CompactOperator #12226

Closed
wants to merge 7 commits into from

Conversation

usberkeley
Copy link
Contributor

Change Logs

In the CompactOperator, the Async Compaction configuration was mistakenly used for executing Compaction Task configurations, resulting in Compaction Tasks only being executed asynchronously when using Async Compaction.

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@usberkeley usberkeley changed the title [HUDI-8498] Fixed the async Compaction task configuration error in CompactOperator [HUDI-8498] Fixed the async compaction task configuration error in CompactOperator Nov 10, 2024
@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Nov 10, 2024
@usberkeley usberkeley marked this pull request as draft November 13, 2024 10:41
@usberkeley usberkeley closed this Nov 20, 2024
@usberkeley usberkeley reopened this Nov 20, 2024
@usberkeley usberkeley changed the title [HUDI-8498] Fixed the async compaction task configuration error in CompactOperator [HUDI-8498] Fix the async compaction task configuration error in CompactOperator Nov 20, 2024
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@usberkeley usberkeley marked this pull request as ready for review November 26, 2024 04:22
@usberkeley
Copy link
Contributor Author

@danny0405 hello, Danny. Could you please help review this?

@usberkeley
Copy link
Contributor Author

usberkeley commented Dec 4, 2024

Background of Flink MOR Compaction

Inline Compaction: Will block writing, sequentially execute Write and Compaction.
Async Compaction: Will not block writing, and not block the checkpoint by executing in thread pool

Why is this PR no longer needed?

This PR implements async compaction + blocking checkpoint (executed in a single thread). In real-world scenarios, users won't use it this way; its only purpose is for CI testing. CC @danny0405 @voonhous

@usberkeley usberkeley closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants