Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error running data fusion queries - Physical input schema should be the same as the one converted from logical input schema #664

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Fix error running data fusion queries - Physical input schema should be the same as the one converted from logical input schema #664

merged 4 commits into from
Nov 28, 2024

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Oct 12, 2024

fixes: #655

@FANNG1 FANNG1 marked this pull request as draft October 12, 2024 09:43
@FANNG1
Copy link
Contributor Author

FANNG1 commented Oct 12, 2024

@a-agmon this's a draft PR, Does it works for you?

@a-agmon
Copy link
Contributor

a-agmon commented Oct 12, 2024

@a-agmon this's a draft PR, Does it works for you?

Hey @FANNG1 , yesss, this works.

note that I had to pin the latest arrow version to resolve some conflict cargo found
arrow = "53.1.0"

@FANNG1
Copy link
Contributor Author

FANNG1 commented Nov 24, 2024

@a-agmon @liurenjie1024 , sorry for the delay, it's ready to review now, please help to review when you have time, thanks

@FANNG1 FANNG1 marked this pull request as ready for review November 24, 2024 01:51
@FANNG1 FANNG1 changed the title [SIP] fix error running data fusion queries - Physical input schema should be the same as the one converted from logical input schema Fix error running data fusion queries - Physical input schema should be the same as the one converted from logical input schema Nov 24, 2024
@a-agmon
Copy link
Contributor

a-agmon commented Nov 24, 2024

LGTM

liurenjie1024
liurenjie1024 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FANNG1 for fixing this.

@liurenjie1024 liurenjie1024 merged commit 6a714ed into apache:main Nov 28, 2024
16 checks passed
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
@FANNG1 @shaeqahmed
Fix error running data fusion queries - Physical input schema should …
c174e7b 
…be the same as the one converted from logical input schema (apache#664)

* xx

* fix comment

* fix comment

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@a-agmon a-agmon a-agmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@FANNG1 @a-agmon @liurenjie1024