[WIP] Spark: DVs + Positional Deletes #11545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
position-delete-tests
branch
2 times, most recently
from
c26e928
to
10e0f33
Compare
nastra
commented
Nov 19, 2024
| Column joinCond = posDeletes.col("file_path").equalTo(dataFiles.col("file_path")); | ||
| Column joinCond = | ||
| posDeletes | ||
| .col(MetadataColumns.DELETE_FILE_PATH.name()) |
There was a problem hiding this comment.
mainly to make it easier to see that those columns refer to the ones from the PositionDeletesTable
nastra
force-pushed
the
position-delete-tests
branch
2 times, most recently
from
6aaedff
to
dd1182a
Compare
nastra
force-pushed
the
position-delete-tests
branch
from
dd1182a
to
8351248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of #11122