Create publish-docker.yml #11632
Create publish-docker.yml #11632
Conversation
|
I was waiting for the account creation. But thanks for working on it. |
|
in addition to pushing the latest, it would be great to publish images tagged with specific releases (1.7/1.8/etc) |
I think many of us are eager to get the docker image in the hub to improve our integration tests in the sub project repositories. Thank you for doing the hard work @ajantha-bhat ! |
Thanks for the suggestion @kevinjqliu - I've added a new trigger for tag push events to publish the docker images with the version tag |
There was a problem hiding this comment.
Ran it on my fork, and it looks good: https://github.com/Fokko/iceberg/actions/runs/12007773313
.github/workflows/publish-docker.yml
Outdated
| run: | | ||
| docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{ secrets.DOCKERHUB_TOKEN }} | ||
| - name: Build Docker Image | ||
| run: docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-adapter-image/Dockerfile . |
There was a problem hiding this comment.
What about using apache/iceberg-rest-fixture ? If we have a consensus, I can rename apache/iceberg.
There was a problem hiding this comment.
I am ok with the name iceberg-rest-fixture, it is a good name 👍
There was a problem hiding this comment.
Sounds good @jbonofre and @ajantha-bhat - I'm good with this new name suggestion as well
|
@Fokko @ajantha-bhat and @jbonofre - thank you all for the reviews on the PR! I've verified the publication using both the
As @jbonofre has already added the dockerhub secrets to the repository, I think we should be good to test the publication through gh actions once we merge this PR |
|
@sungwy Thanks for raising this and the thorough testing. I also did some tests against my personal Dockerhub, so let's push this forward. |
|
I saw that this action was run manually https://github.com/apache/iceberg/actions/runs/12082416551 did we ever set |
|
Hi @kevinjqliu - I think it's because the DOCKERHUB_USER is a different value than I see the following image on dockerhub that was published around the time of the job run: https://hub.docker.com/r/asfjenkins/iceberg-rest-fixture I think @ajantha-bhat is already working on a fix: #11676 |
Pending completion of: https://github.com/apache/iceberg/pull/11283/files