API: Deprecate NestedType.of in favor of builder #12227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Feb 12, 2025
nastra
reviewed
Feb 12, 2025
That's done in #12211. This will be rebased and merged after that one goes in. |
rdblue
force-pushed
the
deprecate-nested-field-of
branch
from
5e0c7a7 to
48137ab
Compare
nastra
approved these changes
Feb 14, 2025
|
LGTM, thanks @rdblue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #12211. While adding support for default values in
UpdateSchema, many of the changes were to use theNestedFieldbuilder's copy constructor,from(NestedField), so that field defaults are not dropped. Dropping defaults is easy to do when using theoffactory method that was previously used to copy fields.This PR deprecates that factory method and removes deprecated uses of
NestedFieldmethods.