-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-23303 Improve transaction performance. #4700
base: main
Are you sure you want to change the base?
Conversation
830f98c
to
e60db81
Compare
|
||
long newLatestTime = max(requestTime.longValue() + 1, max(now, oldLatestTime + 1)); | ||
|
||
// TODO avoid CAS on lower value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend rewriting this method in this way (without TODO). It can skip CAS in cases where the letest clock value is the most one and does not notify a listener in case where the clock is chaged without jump up.
@rpuch Could you approve this approach with the listener?
public HybridTimestamp update(HybridTimestamp requestTime) {
long requestTimeLong = requestTime.longValue();
while (true) {
long now = currentTime();
// Read the latest time after accessing UTC time to reduce contention.
long oldLatestTime = this.latestTime;
if (oldLatestTime >= requestTimeLong && oldLatestTime >= now) {
return hybridTimestamp(LATEST_TIME.incrementAndGet(this));
}
if (now > requestTimeLong) {
if (LATEST_TIME.compareAndSet(this, oldLatestTime, now)) {
return hybridTimestamp(now);
}
} else {
long newLatestTime = requestTimeLong + 1;
if (LATEST_TIME.compareAndSet(this, oldLatestTime, newLatestTime)) {
notifyUpdateListeners(newLatestTime);
return hybridTimestamp(newLatestTime);
}
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it in separate ticket.
I've created https://issues.apache.org/jira/browse/IGNITE-23707
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java
Outdated
Show resolved
Hide resolved
...s/core/src/test/java/org/apache/ignite/internal/util/PendingComparableValuesTrackerTest.java
Show resolved
Hide resolved
...le/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
Outdated
Show resolved
Hide resolved
modules/table/src/testFixtures/java/org/apache/ignite/distributed/ItTxTestCluster.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/hlc/HybridClockTest.java
Show resolved
Hide resolved
...licator/src/main/java/org/apache/ignite/internal/replicator/message/ReplicaMessageGroup.java
Outdated
Show resolved
Hide resolved
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
Show resolved
Hide resolved
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
Outdated
Show resolved
Hide resolved
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaResult.java
Outdated
Show resolved
Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/HybridTimestampTracker.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
Outdated
Show resolved
Hide resolved
…nto ignite-23303
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java
Show resolved
Hide resolved
modules/core/src/testFixtures/java/org/apache/ignite/internal/TestHybridClock.java
Show resolved
Hide resolved
* Tests propagation of HLC on heartbeat request and response. | ||
*/ | ||
@Test | ||
public void testHlcPropagation() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've left lot's of dead code. E.g. there's no longer need to provide HybridClock to Loza nor store it in NodeOptions. It's just an example. I guess there's more code to remove since we no longer need. Curious why it's not a dedicated PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope of additional changes is small, so I decided to include it.
You've left lot's of dead code
I believe this doesn't break anything.
Created a ticket for further cleaning up:
https://issues.apache.org/jira/browse/IGNITE-23742
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket description is empty. Anyone who is not in context won't understand what to do.
...replicator/src/main/java/org/apache/ignite/internal/replicator/CommandApplicationResult.java
Show resolved
Hide resolved
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java
Show resolved
Hide resolved
...replicator/src/main/java/org/apache/ignite/internal/replicator/CommandApplicationResult.java
Show resolved
Hide resolved
...replicator/src/main/java/org/apache/ignite/internal/replicator/CommandApplicationResult.java
Show resolved
Hide resolved
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaResult.java
Show resolved
Hide resolved
@@ -66,6 +66,13 @@ public class UpsertKvBenchmark extends AbstractMultiNodeBenchmark { | |||
@Param({"8"}) | |||
private int partitionCount; | |||
|
|||
private static final AtomicInteger counter = new AtomicInteger(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COUNTER
@@ -1107,7 +1116,7 @@ public CompletableFuture<Void> upsert(BinaryRowEx row, @Nullable InternalTransac | |||
.transactionId(txo.id()) | |||
.enlistmentConsistencyToken(enlistmentConsistencyToken) | |||
.requestType(RW_UPSERT) | |||
.timestamp(clockService.now()) | |||
.timestamp(txo.startTimestamp()) // TODO https://issues.apache.org/jira/browse/IGNITE-23712 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't look right. Every request should send currentTimestamp. Within proposal you will send same time with multiple inserts within same transaction.
https://issues.apache.org/jira/browse/IGNITE-23303
Major changes in PR:
Benchmark results (Xeon(R) Silver 4314):
32 threads
Before (rev d6d402d)
Benchmark (batch) (fsync) (partitionCount) Mode Cnt Score Error Units
UpsertKvBenchmark.upsert 1 false 64 thrpt 20 442348.635 ± 14953.282 ops/s
After
Benchmark (batch) (fsync) (partitionCount) Mode Cnt Score Error Units
UpsertKvBenchmark.upsert 1 false 64 thrpt 20 675504.465 ± 40299.612 ops/s