IGNITE-23213 #4755
Open
IGNITE-23213 #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldpyatkov
reviewed
Nov 20, 2024
| @@ -537,7 +537,7 @@ private void updateLeaseBatchInternal() { | |||
| ); | |||
| } | |||
|
|
|||
| if (Arrays.equals(leasesCurrent.leasesBytes(), renewedValue)) { | |||
| if (renewedLeases.isEmpty() || Arrays.equals(leasesCurrent.leasesBytes(), renewedValue)) { | |||
There was a problem hiding this comment.
Why cannot we remove all leases?
| public void createAgreement(ReplicationGroupId groupId, Lease lease) { | ||
| leaseToNegotiate.put(groupId, new LeaseAgreement(lease)); | ||
| @Nullable | ||
| public Lease createAgreement(ReplicationGroupId groupId, Lease lease) { |
There was a problem hiding this comment.
Why don't return boolean?
| public void stopInhibit() { | ||
| inhibitFuture.complete(null); | ||
| } | ||
| } |
There was a problem hiding this comment.
surprisingly, checkstyle doesn't check it
| * @return A lease. | ||
| * @throws InterruptedException if the wait is interrupted. | ||
| */ | ||
| private Lease awaitForLease(boolean needAccepted, @Nullable Lease previousLease) throws InterruptedException { |
There was a problem hiding this comment.
I did not find where previousLease is used.
| } | ||
|
|
||
| private void waitForAcceptedLease() throws InterruptedException { | ||
| assertTrue(waitForCondition(() -> { | ||
| Lease lease = getLeaseFromMs(); | ||
| log.info("qqq lease=" + lease); |
| @@ -201,6 +206,8 @@ public void testAssignmentChangeOnNegotiation() throws InterruptedException { | |||
|
|
|||
| metaStorageManager.put(stablePartAssignmentsKey(GROUP_ID), Assignments.toBytes(Set.of(forPeer(NODE_1_NAME)), assignmentsTimestamp)); | |||
|
|
|||
| System.out.println("qwe"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23213