IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses #5479
+197
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korlov42
requested changes
Mar 26, 2025
| @@ -700,34 +700,48 @@ private void checkIntegerLimit(@Nullable SqlNode n, String nodeName) { | |||
| } | |||
|
|
|||
| if (n instanceof SqlLiteral) { | |||
| BigDecimal offFetchLimit = ((SqlLiteral) n).bigDecimalValue(); | |||
| BigDecimal offsetFetchLimit = ((SqlLiteral) n).bigDecimalValue(); | |||
There was a problem hiding this comment.
let's also improve method's javadoc
| } | ||
|
|
||
| if (param instanceof BigDecimal) { | ||
| checkLimitOffset((BigDecimal) param, n, nodeName); |
There was a problem hiding this comment.
there is no point in validation of particular value of dynamic parameter on preparation stage since validation is happening once, and then plan will be reused for different arguments
There was a problem hiding this comment.
got it, move into execution phase
lowka
reviewed
Mar 26, 2025
| # decimal limit | ||
| query I | ||
| SELECT a FROM test ORDER BY a LIMIT 1.6 | ||
| ---- |
There was a problem hiding this comment.
Perhaps we can check FETCH .... ROWS syntax as well?
zstan
commented
Mar 27, 2025
| @@ -1158,4 +1144,20 @@ private static boolean canFuseProjectionInto(RelNode rel) { | |||
|
|
|||
| return joinProjection; | |||
| } | |||
|
|
|||
| private long validateAndGetFetchOffsetParams(RexNode node, String op) { | |||
There was a problem hiding this comment.
probably we can move this check into Node code and append additional tests if it helpful with another issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes