-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): add metric api doc #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could format the doc with IDEA plugins (refer #282 (comment))
And sync the EN doc later (after CN doc almost done)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could format the doc with IDEA plugins (refer #282 (comment))
And sync the EN doc later (after CN doc almost done)
yes.
BTW, another topic, the hg code dont follow hg style totaly, so if we enable auto save, it will change some hg code unexpectedly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could format the doc with IDEA plugins (refer #282 (comment))
And sync the EN doc later (after CN doc almost done)yes.
BTW, another topic, the hg code dont follow hg style totaly, so if we enable auto save, it will change some hg code unexpectedly?
Yes, this is a legacy issue from history, as plugins and style were added later and can only be adjusted locally/multiple times 🔢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could format the doc with IDEA plugins (refer #282 (comment))
And sync the EN doc later (after CN doc almost done)yes.
BTW, another topic, the hg code dont follow hg style totaly, so if we enable auto save, it will change some hg code unexpectedly?Yes, this is a legacy issue from history, as plugins and style were added later and can only be adjusted locally/multiple times 🔢
Get it, but maybe some pr will be reject for changing the origin old code style (such as 'nextLine') which using hg-style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it, but maybe some pr will be reject for changing the origin old code style (such as 'nextLine') which using hg-style.
could u show some example? We could choose the proper one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i remember this:apache/incubator-hugegraph#2286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i remember this:apache/incubator-hugegraph#2286
Maybe no need to align like that, should keep with the auto format style as much as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also sync CN version
we dont have metric api doc,so user even dont know it.