Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add metric api doc #295

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

SunnyBoy-WYH
Copy link
Contributor

we dont have metric api doc,so user even dont know it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could format the doc with IDEA plugins (refer #282 (comment))

And sync the EN doc later (after CN doc almost done)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could format the doc with IDEA plugins (refer #282 (comment))

And sync the EN doc later (after CN doc almost done)

yes.

BTW, another topic, the hg code dont follow hg style totaly, so if we enable auto save, it will change some hg code unexpectedly?

Copy link
Member

@imbajin imbajin Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could format the doc with IDEA plugins (refer #282 (comment))
And sync the EN doc later (after CN doc almost done)

yes.

BTW, another topic, the hg code dont follow hg style totaly, so if we enable auto save, it will change some hg code unexpectedly?

Yes, this is a legacy issue from history, as plugins and style were added later and can only be adjusted locally/multiple times 🔢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could format the doc with IDEA plugins (refer #282 (comment))
And sync the EN doc later (after CN doc almost done)

yes.
BTW, another topic, the hg code dont follow hg style totaly, so if we enable auto save, it will change some hg code unexpectedly?

Yes, this is a legacy issue from history, as plugins and style were added later and can only be adjusted locally/multiple times 🔢

Get it, but maybe some pr will be reject for changing the origin old code style (such as 'nextLine') which using hg-style.

Copy link
Member

@imbajin imbajin Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it, but maybe some pr will be reject for changing the origin old code style (such as 'nextLine') which using hg-style.

could u show some example? We could choose the proper one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@imbajin imbajin Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember this:apache/incubator-hugegraph#2286 image

Maybe no need to align like that, should keep with the auto format style as much as possible

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also sync CN version

content/en/docs/clients/restful-api/metrics.md Outdated Show resolved Hide resolved
content/en/docs/clients/restful-api/metrics.md Outdated Show resolved Hide resolved
@imbajin imbajin merged commit 08fb3a1 into apache:master Nov 14, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants