Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): update license for 1.2.0 #2391

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Conversation

SunnyBoy-WYH
Copy link
Contributor

Purpose of the PR

hugegraph/actions#6

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4346b44) 66.27% compared to head (7b29e0f) 66.29%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2391      +/-   ##
============================================
+ Coverage     66.27%   66.29%   +0.02%     
+ Complexity      830      828       -2     
============================================
  Files           511      511              
  Lines         42590    42590              
  Branches       5941     5941              
============================================
+ Hits          28227    28237      +10     
+ Misses        11558    11550       -8     
+ Partials       2805     2803       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin
imbajin previously approved these changes Dec 17, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

But too big to review the details in UI, search it in local IDE soon

@SunnyBoy-WYH
Copy link
Contributor Author

Thanks~

But too big to review the details in UI, search it in local IDE soon

Do we have any pre-check tool to vertify it? so we can dont need check until release landing.

@simon824
Copy link
Member

simon824 commented Dec 18, 2023

Permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both the copyright notice and this permission notice and warranty disclaimer appear in supporting documentation, and that the names of the authors or their employers not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission.

The authors and their employers disclaim all warranties with regard to this software, including all implied warranties of merchantability and fitness. In no event shall the authors or their employers be liable for any special, indirect or consequential damages or any damages whatsoever resulting from loss of use, data or profits, whether in an action of contract, negligence or other tortious action, arising out of or in connection with the use or performance of this software.
This is an open source license. It is also GPL-Compatible (see entry for "Standard ML of New Jersey"). The portions of CUP output which are hard-coded into the CUP source code are (naturally) covered by this same license, as is the CUP runtime code linked with the generated parser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it is not clear from the file what license this dependency is based on. And this license contains GPL keywords, which should be noted and removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it is not clear from the file what license this dependency is based on. And this license contains GPL keywords, which should be noted and removed.

consider remove the unnecessary NOTICE part from upstream

@imbajin imbajin merged commit 7635c67 into apache:master Dec 19, 2023
21 checks passed
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024

---------

Co-authored-by: liuxiao <[email protected]>
Co-authored-by: Simon Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants