fix(server): change the arthas bind ip #2429
Conversation
dosubot
bot
added
size:XS
# Conflicts: # hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
|
ci error: [INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hugegraph.api.ApiTestSuite
Error: Tests run: 98, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 22.391 s <<< FAILURE! - in org.apache.hugegraph.api.ApiTestSuite
Error: testArthasApi(org.apache.hugegraph.api.ArthasApiTest) Time elapsed: 4.222 s <<< FAILURE!
java.lang.AssertionError: Response with status 200 and content {"body":{"command":"version","jobId":2,"jobStatus":"TERMINATED","results":[{"jobId":2,"type":"version","version":"3.7.1"},{"jobId":2,"statusCode":0,"type":"status"}],"timeExpired":false},"sessionId":"84ec7575-e343-4d61-8b36-e0e1da8b276c","state":"SUCCEEDED"} expected:<401> but was:<200>
at org.apache.hugegraph.api.ArthasApiTest.testArthasApi(ArthasApiTest.java:56) |
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2429 +/- ##
============================================
+ Coverage 56.94% 66.28% +9.34%
- Complexity 827 829 +2
============================================
Files 612 511 -101
Lines 49672 42622 -7050
Branches 6681 5947 -734
============================================
- Hits 28284 28251 -33
+ Misses 18572 11563 -7009
+ Partials 2816 2808 -8 ☔ View full report in Codecov by Sentry. |
| "0.0.0.0" | ||
| "127.0.0.1" |
There was a problem hiding this comment.
any context for it (change the IP to localhost)?
There was a problem hiding this comment.
the context you can see the introduction about this issue. i think 0.0.0.0 means any ip, and arthas will set default password, sometime the ci failed.
why prefer localhost not 127.0.0.1? the config item provided by arthas named 'arthas.ip',im not sure localhost as a domain will work.
|
|
||
| RestClient arthasApiClientWithAuth = new RestClient(ARTHAS_API_BASE_URL); | ||
| r = arthasApiClientWithAuth.post(ARTHAS_API_PATH, body); | ||
| assertResponseStatus(401, r); |
There was a problem hiding this comment.
can we add some exception cases for invalid requests
There was a problem hiding this comment.
Yes we will do later
# Conflicts: # hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java
dosubot
bot
added
size:XS
sometime arthas test failed, see https://github.com/apache/incubator-hugegraph/actions/runs/7652616070/job/20852745753?pr=2408