Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine the hg-style.xml specification #2454

Closed
wants to merge 0 commits into from
Closed

chore: refine the hg-style.xml specification #2454

wants to merge 0 commits into from

Conversation

returnToInnocence
Copy link
Contributor

Purpose of the PR

Main Changes

  • Change the maximum wrap text length for XML and Java to 120 —— hard wrap at should be set to 120.
  • Add a blank line between method definitions, inner class definitions, and static code blocks —— after the anonymous class header and before the method body.
  • For Properties files, add the option "KEEP_BLANK_LINES."
  • Adjust the overall indentation to 4, following the indentation conventions of the save action.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ci-cd Build or deploy labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (5cb9aad) 66.25% compared to head (786213f) 66.24%.

Files Patch % Lines
...n/java/org/apache/hugegraph/api/graph/EdgeAPI.java 54.54% 7 Missing and 8 partials ⚠️
...java/org/apache/hugegraph/api/graph/VertexAPI.java 7.14% 12 Missing and 1 partial ⚠️
.../org/apache/hugegraph/opencypher/CypherPlugin.java 0.00% 6 Missing ⚠️
...egraph/backend/store/cassandra/CassandraShard.java 37.50% 5 Missing ⚠️
...egraph/backend/store/cassandra/CassandraStore.java 50.00% 4 Missing and 1 partial ⚠️
.../java/org/apache/hugegraph/api/graph/BatchAPI.java 33.33% 4 Missing ⚠️
.../apache/hugegraph/api/filter/LoadDetectFilter.java 25.00% 3 Missing ⚠️
...ain/java/org/apache/hugegraph/api/job/TaskAPI.java 0.00% 3 Missing ⚠️
...egraph/backend/store/cassandra/CassandraTable.java 62.50% 1 Missing and 2 partials ⚠️
...raph/backend/store/rocksdb/RocksDBStdSessions.java 81.25% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2454      +/-   ##
============================================
- Coverage     66.25%   66.24%   -0.01%     
- Complexity      827      828       +1     
============================================
  Files           511      511              
  Lines         42586    42590       +4     
  Branches       5935     5939       +4     
============================================
+ Hits          28214    28215       +1     
- Misses        11563    11569       +6     
+ Partials       2809     2806       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title chore(hg-style.xml): refine the hg-style.xml specification chore: refine the hg-style.xml specification Feb 21, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 21, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant