-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pd): integrate pd-service
into hugegraph
#2528
Conversation
@imbajin Should we remove all content under |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2528 +/- ##
============================================
- Coverage 57.25% 57.13% -0.12%
+ Complexity 829 827 -2
============================================
Files 605 608 +3
Lines 49334 49415 +81
Branches 6639 6645 +6
============================================
- Hits 28246 28234 -12
- Misses 18280 18366 +86
- Partials 2808 2815 +7 ☔ View full report in Codecov by Sentry. |
hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/rest/StoreAPI.java
Dismissed
Show dismissed
Hide dismissed
|
||
public class API { | ||
|
||
public static final String VERSION = "3.6.3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static final String VERSION = "3.6.3"; | |
public static final String VERSION = "1.5.0"; |
do we need change it? (or we could read the param from pom's revision)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -31,7 +32,8 @@ | |||
|
|||
public class API { | |||
|
|||
public static final String VERSION = "3.6.3"; | |||
// Currently reading directly from the pom. | |||
public static final String VERSION = VersionUtil.getPomVersion(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARN: If a user env doesn't install the maven
, it will throw error?
or may consider using this way:
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration>
</plugin>
</plugins>
</build>
public static String getPomVersion() {
// read the version in *.jar (can't read it in IDE runtime)
return this.getClass().getPackage().getImplementationVersion();
}
TODO: Update the implement in the common-module
leave a TODO to enhance it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly move ⌚️
subtask of #2265
For detailed module analysis documentation, please refer to this link.