Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pd): integrate pd-service into hugegraph #2528

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Conversation

VGalaxies
Copy link
Contributor

subtask of #2265

For detailed module analysis documentation, please refer to this link.

@VGalaxies VGalaxies requested a review from imbajin April 20, 2024 08:04
@VGalaxies VGalaxies self-assigned this Apr 20, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature pd PD module labels Apr 20, 2024
@VGalaxies
Copy link
Contributor Author

VGalaxies commented Apr 20, 2024

@imbajin Should we remove all content under license and upgrade packages? Or mark them when merging with the Useless annotation from pd-store branch later?

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 57.13%. Comparing base (43cae1d) to head (865566d).

Files Patch % Lines
...graph/pd/upgrade/scripts/PartitionMetaUpgrade.java 0.00% 52 Missing ⚠️
...hugegraph/pd/upgrade/scripts/TaskCleanUpgrade.java 0.00% 16 Missing ⚠️
...che/hugegraph/pd/upgrade/VersionScriptFactory.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2528      +/-   ##
============================================
- Coverage     57.25%   57.13%   -0.12%     
+ Complexity      829      827       -2     
============================================
  Files           605      608       +3     
  Lines         49334    49415      +81     
  Branches       6639     6645       +6     
============================================
- Hits          28246    28234      -12     
- Misses        18280    18366      +86     
- Partials       2808     2815       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies
Copy link
Contributor Author

@imbajin Should we remove all content under license and upgrade packages? Or mark them when merging with the Useless annotation from pd-store branch later?

@imbajin marked with Useless now


public class API {

public static final String VERSION = "3.6.3";
Copy link
Member

@imbajin imbajin Apr 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final String VERSION = "3.6.3";
public static final String VERSION = "1.5.0";

do we need change it? (or we could read the param from pom's revision)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change may have minimal impact; currently reading directly from the pom.

image

@@ -31,7 +32,8 @@

public class API {

public static final String VERSION = "3.6.3";
// Currently reading directly from the pom.
public static final String VERSION = VersionUtil.getPomVersion();
Copy link
Member

@imbajin imbajin Apr 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN: If a user env doesn't install the maven, it will throw error?

or may consider using this way:

<build>
    <plugins>
        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-jar-plugin</artifactId>
            <configuration>
                <archive>
                    <manifest>
                        <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                    </manifest>
                </archive>
            </configuration>
        </plugin>
    </plugins>
</build>
public static String getPomVersion() {
    // read the version in *.jar (can't read it in IDE runtime)
    return this.getClass().getPackage().getImplementationVersion();
}

TODO: Update the implement in the common-module

leave a TODO to enhance it
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly move ⌚️

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2024
@imbajin imbajin added this to the 1.5.0 milestone Apr 22, 2024
@imbajin imbajin merged commit 2b3bc4f into master Apr 22, 2024
14 checks passed
@imbajin imbajin deleted the intro-pd-service branch April 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature lgtm This PR has been approved by a maintainer pd PD module size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants