-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: intro editorconfig-maven-plugin
for verifying code style defined in .editorconfig
#2591
Conversation
.editorconfig
editorconfig-maven-plugin
for validating and appling code style in .editorconfig
editorconfig-maven-plugin
for validating and appling code style in .editorconfig
editorconfig-maven-plugin
for validating code style in .editorconfig
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2591 +/- ##
============================================
+ Coverage 51.31% 52.56% +1.25%
+ Complexity 679 586 -93
============================================
Files 643 643
Lines 53364 53364
Branches 7017 7017
============================================
+ Hits 27382 28051 +669
+ Misses 23223 22474 -749
- Partials 2759 2839 +80 ☔ View full report in Codecov by Sentry. |
editorconfig-maven-plugin
for validating code style in .editorconfig
editorconfig-maven-plugin
for verifying code style in .editorconfig
editorconfig-maven-plugin
for verifying code style in .editorconfig
editorconfig-maven-plugin
for verifying code style defined in .editorconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, maybe could paste a screenshot for it?
And wonder to know if the old files break the rule, what will happen? (Stop building? Or just warn it?)
PS: The approve button was clicked by mistake and can be ignored :)
In the verify phase, the code style will be checked, and if it does not comply, an error will be reported, as shown in the figure below: Important: It has been found that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX~ (Could sync to toolchain later)
follow up #2561
mvn editorconfig:format
for one-click code formatting