Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lombok compiling error and error for list cast to string #2592

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

zyxxoo
Copy link
Contributor

@zyxxoo zyxxoo commented Jul 16, 2024

fix Fatal error compiling:
java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid'

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Incompatible dependencies of package labels Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.64%. Comparing base (a657ce5) to head (da4a11c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2592      +/-   ##
============================================
+ Coverage     47.56%   47.64%   +0.08%     
  Complexity      820      820              
============================================
  Files           718      718              
  Lines         58490    58490              
  Branches       7496     7496              
============================================
+ Hits          27821    27870      +49     
+ Misses        27889    27832      -57     
- Partials       2780     2788       +8     
Flag Coverage Δ
47.64% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -34,7 +34,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.20</version>
<version>1.18.30</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use a unified version property for it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@imbajin imbajin changed the title upgrade lombok version chore: fix lombok compiling error Jul 16, 2024
@@ -34,7 +34,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.20</version>
<version>1.18.30</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the lombok dependency:
since we don't have a large places to generate/replace code, and in the few places where it's necessary, I would rather write some code manually to maintain a consistent style.

@minaxolone
Copy link

@zyxxoo The version also needs to be bumped in hg-pd-common.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 24, 2024
@zyxxoo zyxxoo force-pushed the fix_vaughn branch 2 times, most recently from c2dc5a7 to c33376f Compare August 24, 2024 14:19
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 24, 2024
@zyxxoo zyxxoo requested a review from imbajin August 24, 2024 15:25
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.30</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add <optional>true</optional> and provide scope for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the optional mean don't transfer dependency, for example, A -> B -> C, if B. use. optional true to c, the A will not reference C
so the optional in our code maybe don't importament

<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.30</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss here?

Copy link
Contributor Author

@zyxxoo zyxxoo Aug 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the code is in dependencymanager

@javeme
Copy link
Contributor

javeme commented Sep 22, 2024

TODO:
Can we remove the lombok dependency:
since we don't have a large places to generate/replace code, and in the few places where it's necessary, I would rather write some code manually to maintain a consistent style.

javeme
javeme previously approved these changes Sep 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 22, 2024
@zyxxoo zyxxoo changed the title chore: fix lombok compiling error chore: fix lombok compiling error and config error for list cast to string Sep 27, 2024
@zyxxoo zyxxoo changed the title chore: fix lombok compiling error and config error for list cast to string chore: fix lombok compiling error and error for list cast to string Sep 27, 2024
@zyxxoo zyxxoo requested review from imbajin, VGalaxies and javeme and removed request for imbajin September 27, 2024 08:34
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: replace each 3rd-level-module deps by 2nd-level-module dep

@VGalaxies VGalaxies merged commit 4274b72 into master Sep 28, 2024
18 checks passed
@VGalaxies VGalaxies deleted the fix_vaughn branch September 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Incompatible dependencies of package lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants