Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hstore): translate CJK comments to English #2616

Merged
merged 8 commits into from
Aug 10, 2024
Merged

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Aug 4, 2024

subtask of #2575

Except for https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/space/GraphSpace.java#L32, and some Chinese characters are introduced certain tests, there should be no CJK characters in the server module.

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (c231a6f) to head (b2b1314).

Files Patch % Lines
.../java/org/apache/hugegraph/type/HugeTableType.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2616      +/-   ##
============================================
- Coverage     47.22%   47.18%   -0.04%     
  Complexity      583      583              
============================================
  Files           718      718              
  Lines         58441    58441              
  Branches       7492     7492              
============================================
- Hits          27596    27575      -21     
- Misses        28068    28083      +15     
- Partials       2777     2783       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies changed the title style(hstore): translate Chinese comment to English chore(hstore): translate CJK comments to English Aug 4, 2024
@VGalaxies VGalaxies marked this pull request as ready for review August 6, 2024 13:16
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 6, 2024
@VGalaxies VGalaxies requested a review from imbajin August 6, 2024 13:16
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@JackyYangPassion JackyYangPassion merged commit 7df736a into master Aug 10, 2024
14 of 17 checks passed
@JackyYangPassion JackyYangPassion deleted the trans-hstore branch August 10, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants