Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): optimize the server-node info #2671

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

zyxxoo
Copy link
Contributor

@zyxxoo zyxxoo commented Sep 29, 2024

when the node info exist, huge can wait some time to wait the time expire ranther than throw error

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 47.78%. Comparing base (f6f3708) to head (b5bb6ff).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...a/org/apache/hugegraph/task/ServerInfoManager.java 21.42% 10 Missing and 1 partial ⚠️
...g/apache/hugegraph/task/StandardTaskScheduler.java 75.00% 1 Missing and 1 partial ⚠️
...java/org/apache/hugegraph/task/HugeServerInfo.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2671      +/-   ##
============================================
+ Coverage     47.68%   47.78%   +0.09%     
  Complexity      821      821              
============================================
  Files           719      719              
  Lines         58914    58918       +4     
  Branches       7595     7597       +2     
============================================
+ Hits          28096    28153      +57     
+ Misses        28007    27949      -58     
- Partials       2811     2816       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 29, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 8, 2024
@imbajin imbajin changed the title optimize refact(server): optimize the server-node info Oct 8, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 8, 2024
imbajin

This comment was marked as outdated.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@imbajin imbajin requested a review from VGalaxies October 8, 2024 14:45
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosu could u give some suggestion for this PR?

@VGalaxies VGalaxies merged commit 861a100 into master Oct 10, 2024
17 of 18 checks passed
@VGalaxies VGalaxies changed the title refact(server): optimize the server-node info refactor(server): optimize the server-node info Oct 10, 2024
@VGalaxies VGalaxies deleted the fix_vaughn branch October 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants