Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Default Store with HStore #2673

Closed
wants to merge 1 commit into from

Conversation

JackyYangPassion
Copy link
Contributor

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working store Store module labels Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.86%. Comparing base (4274b72) to head (539ef36).

❗ There is a different number of reports uploaded between BASE (4274b72) and HEAD (539ef36). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (4274b72) HEAD (539ef36)
7 2
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2673      +/-   ##
============================================
- Coverage     47.55%   37.86%   -9.70%     
+ Complexity      820      541     -279     
============================================
  Files           718      718              
  Lines         58490    58490              
  Branches       7496     7496              
============================================
- Hits          27817    22148    -5669     
- Misses        27890    33957    +6067     
+ Partials       2783     2385     -398     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] Change Server Config default KV Store from rocksDB to HStore
1 participant