Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#520: Replace copyright headers/comments on kie-benchmarks as part of the migration to Apache #500 #520 #257

Merged
merged 1 commit into from
Jan 17, 2024
Merged

kie-issues#520: Replace copyright headers/comments on kie-benchmarks as part of the migration to Apache #500 #520 #257

merged 1 commit into from
Jan 17, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Aug 30, 2023 •
edited by yesamer
Loading

@ederign ederign mentioned this pull request Aug 30, 2023
Closed
@ederign ederign requested a review from lucamolteni September 5, 2023 18:29
@ederign
Copy link
Member Author

ederign commented Sep 5, 2023

@lucamolteni, when you have a chance, could you please review this? Its part of Apache migration

@kbowers-ibm kbowers-ibm self-assigned this Nov 20, 2023
@kbowers-ibm kbowers-ibm self-requested a review November 20, 2023 15:46
@kbowers-ibm kbowers-ibm removed their assignment Nov 20, 2023
kbowers-ibm
kbowers-ibm approved these changes Nov 20, 2023
View reviewed changes
Copy link

@kbowers-ibm kbowers-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Once merge conflicts resolved)

@yesamer
Copy link

yesamer commented Nov 20, 2023

@ederign Can you please resolve the conflict?

@LightGuard
Copy link

Conflicting commit: 24479c4

The SimpleDummyFactsMatchRatioExpertBenchmark.java file was deleted. It should be a very simple conflict cleanup :)

@yesamer
Copy link

yesamer commented Jan 16, 2024

@ederign We just need to merge this PR to close the whole Headers refactoring task 💪 🔥
Can you please resolve the above conflict? Thanks! 🙏

@ederign
kie-issues#500: Replace copyright headers/comments on kie-benchmarks …
f9c13e9 
…as part of the migration to Apache #500 #520
@ederign
Copy link
Member Author

ederign commented Jan 16, 2024

@yesamer fixed.

yesamer
yesamer approved these changes Jan 16, 2024
View reviewed changes
Copy link

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ederign

@yesamer
Copy link

yesamer commented Jan 16, 2024

@LightGuard Do you think we can merge it? Is java 11 build failure unrelated?

@LightGuard
Copy link

I don't have any issues merging this.

@LightGuard
Copy link

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project drools-benchmarks-common: Fatal error compiling: error: invalid target release: 17 -> [Help 1]

Makes sense, code targeted for 17 can't compile on a version 11 JDK :)

@yesamer yesamer merged commit df8e1d4 into apache:main Jan 17, 2024
1 of 2 checks passed
@yesamer yesamer changed the title kie-issues#500: Replace copyright headers/comments on kie-benchmarks as part of the migration to Apache #500 #520 kie-issues#520: Replace copyright headers/comments on kie-benchmarks as part of the migration to Apache #500 #520 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbowers-ibm kbowers-ibm kbowers-ibm approved these changes

@yesamer yesamer yesamer approved these changes

@mariofusco mariofusco mariofusco approved these changes

@LightGuard LightGuard LightGuard approved these changes

@lucamolteni lucamolteni Awaiting requested review from lucamolteni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace copyright headers/comments on kie-benchmarks as part of the migration to Apache #500
5 participants
@ederign @yesamer @LightGuard @mariofusco @kbowers-ibm