Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIE-ISSUES 1056 - Introduce AuthZ Guide for SonataFlow Deployments #614

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

ricardozanini
Copy link
Member

Closes apache/incubator-kie-issues#1056

Depends on apache/incubator-kie-kogito-examples#1902

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🎊 PR Preview bdb1690 has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-614.surge.sh

@ricardozanini ricardozanini marked this pull request as ready for review April 5, 2024 20:25
Signed-off-by: Ricardo Zanini <[email protected]>
Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini I did first round of review (mostly little typos).

I noticed 2 more points:

  1. Sometimes you are using modal auxiliary verbs as "will", "should", "can". Shouldn't we use just present tense? + removing you're
  2. Looking at the tooling guides and we use bold labels for the UI components. In this guide you use apostrophes. I would suggest to use also the bold text. Wdyt?

If you agree, I can go through the guide and make all the suggestions. 🙂

@ricardozanini
Copy link
Member Author

@ricardozanini I did first round of review (mostly little typos).

I noticed 2 more points:

  1. Sometimes you are using modal auxiliary verbs as "will", "should", "can". Shouldn't we use just present tense? + removing you're
  2. Looking at the tooling guides and we use bold labels for the UI components. In this guide you use apostrophes. I would suggest to use also the bold text. Wdyt?

If you agree, I can go through the guide and make all the suggestions. 🙂

Nice suggestions, please go ahead!

Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a second round, I tried to remove the future tense and replace ui componentss apostrophes with the bold text.

I will do one more to test the documentation together with the example.

Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini Thanks a lot for all the changes 😊. Few more findings when I tested the example together with the documentation.

  1. I missed few more ui elements and names to be wrapped with ` or *.
  2. I updated 02-sonataflow-route.yaml to be exactly same as in the example.
  3. I replaced INGRESS_PORT with INGRESS_URL. The url may differs on different environmetns.

@ricardozanini
Copy link
Member Author

Thank you @tomasdavidorg I appreciate the thorough review! You can check now your changes in the preview.

@tomasdavidorg
Copy link
Contributor

tomasdavidorg commented Apr 11, 2024

Thank you @tomasdavidorg I appreciate the thorough review! You can check now your changes in the preview.

Checked and looks good to me. Thanks again 🙂.

@ricardozanini
Copy link
Member Author

Thank you for checking, this one was a hell to put together.

Copy link
Contributor

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have added a couple of nitpicks if you want to consider adding.

@domhanak domhanak removed their request for review April 16, 2024 09:58
Co-authored-by: Walter Medvedeo <[email protected]>
@ricardozanini
Copy link
Member Author

@kaldesai can you ptal?

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions! Otherwise, your content looks good to me. Very well written. Thank you!

Co-authored-by: Kalyani Desai <[email protected]>
@ricardozanini ricardozanini merged commit 9a25a3f into apache:main Apr 18, 2024
2 checks passed
@ricardozanini ricardozanini deleted the kie-issues-1056 branch April 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC - SonataFlow: Introduce a guide and example about using APISIX Gateways to introduce security use cases
5 participants