-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about Knative deployment model in the operator #624
Conversation
Signed-off-by: Ricardo Zanini <[email protected]>
🎊 PR Preview 9a25a3f has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-624.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just spot one typo. The rest LGTM
serverlessworkflow/modules/ROOT/pages/cloud/operator/customize-podspec.adoc
Outdated
Show resolved
Hide resolved
…-podspec.adoc Co-authored-by: Jakub Schwan <[email protected]>
Need to add a note about Knative not supporting |
@wmedvede can you PTAL? |
Signed-off-by: Ricardo Zanini <[email protected]>
|
||
The exception are workflows that have callback states. In this case, you must configure xref:cloud/operator/using-persistence.adoc[persistence]. This is required because once the workflow waits for the event to resume the execution, Knative will kill the pod. Since the workflow has persistence, it will resume the execution once it receives the callback event. | ||
|
||
Knative **does not support** link:{kubernetes_init_containers}[`initContainers`] by default. If your workflow requires it, you must first enable the extension in the Knative installation. See more information on the link:{knative_serving_initcontainer}[Knative documentation]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, didn't know that
Closes apache/incubator-kie-kogito-serverless-operator#385
Description:
In this PR, we add a brief explanation about deploying workflows as Knative Services.
Depends on apache/incubator-kie-kogito-serverless-operator#447
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject
[0.9.x] Issue-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.