kie-issues#1255: agent docker config in main pipeline #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstastny-cz
force-pushed
the
agent-config-main-yaml
branch
from
afd328e to
0dcd9eb
Compare
jstastny-cz
changed the title
This was referenced May 24, 2024
baldimir
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly fix
Adding jenkins agent docker configuration to .ci/config/main.yaml
Also in:
There are jobs already in main pipeline (either root folder or defined in dsl/seed_job_branch.groovy file), which didn't have access to jenkins agent docker image and args configuration from branch.yaml - because that one is loaded only in Jenkinsfile.seed.branch - which did not make it possible to reference these values already in dsl/seed_job_branch.groovy.
So adding the agent docker configuration into main.yaml and loading already in Jenkinsfile.seed.main, so that all DSL jobs are able to use this value loaded from particular branch (except from the dsl/seed_job_main.groovy which is the actual first entry point into DSL generation and no docker config is needed there as of now).