Skip to content

Commit

Permalink
[issue-368] knative integration with DataIndex and JobService: fix wo…
Browse files Browse the repository at this point in the history
…rkflow deletion hanging issue
  • Loading branch information
jianrongzhang89 committed Sep 6, 2024
1 parent 449afcf commit db0c4bd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion controllers/profiles/common/constants/platform_services.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const (
JobServiceJobEventsPath = "/v2/jobs/events"
JobServiceLeaderCheckExpirationInSeconds = "kogito.jobs-service.management.leader-check.expiration-in-seconds"
DefaultJobServiceLeaderCheckExpirationInSeconds = "60"
JobServiceRequestEventsURL = "mp.messaging.outgoing.kogito-job-service-job-request-events.url"

KogitoProcessInstancesEventsConnector = "mp.messaging.outgoing.kogito-processinstances-events.connector"
KogitoProcessInstancesEventsMethod = "mp.messaging.outgoing.kogito-processinstances-events.method"
Expand Down
2 changes: 1 addition & 1 deletion controllers/sonataflow_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (r *SonataFlowReconciler) setDefaults(workflow *operatorapi.SonataFlow) {

func (r *SonataFlowReconciler) cleanupTriggers(ctx context.Context, workflow *operatorapi.SonataFlow) error {
plf, _ := platform.GetActivePlatform(ctx, r.Client, workflow.Namespace)
if plf == nil || len(plf.Status.Triggers) == 0 {
if plf == nil || len(workflow.Status.Triggers) == 0 {
return nil
}
avail, err := knative.GetKnativeAvailability(r.Config)
Expand Down

0 comments on commit db0c4bd

Please sign in to comment.