-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9265] Add the PodSpecTemplate to the SonataFlow CR #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the SonataFlow status, when an image is specified, the condition states the following:
status:
address: {}
conditions:
- lastUpdateTime: "2023-09-19T08:32:17Z"
status: Unknown
type: Built
Perhaps when an image is specified the status can be set to Obsolete or Skipped to highlight no build was executed by this flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually Unknown
is the convention, but I liked Skipped
for this use case. I'll add it. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masayag what I did was Built = False, Reason: BuildSkipped. Can you give it a try?
Signed-off-by: Ricardo Zanini <[email protected]>
c229558
to
0872822
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments in case it could make sense and some silly questions.
Thanks.
Signed-off-by: Ricardo Zanini <[email protected]>
@wmedvede I've made small changes to the API to reflect the PodTemplateSpec naming. Not sure why I inverted, might be a brain fart or due to discussions with @masayag. We used to call it that. @masayag wanna chime in about the naming change in the API? Basically, we now have |
Signed-off-by: Ricardo Zanini <[email protected]>
Description of the change:
In this PR:
controllers/profiles
method. Now more clear and easier to maintain. Each profile has its own module and a common one to share features between them. Smaller names, funcs, and revisited structs. Unused code removed.SonataFlow
CRD is huge (thanks,podSpecTemplate
!) we needed to change fromkubectl apply
tokubectl create
in CRDs creation. I'll try to revisit the makefile since thedeploy
andinstall
are trying to apply the same artifacts. The first one should only install the CRDs, the latter the other resources.TODO:
podSpecTemplate
considering the specific user's custom template. Add guards to not override the controller's defaults like volumes, container name and etc.Motivation for the change:
See https://issues.redhat.com/browse/KOGITO-9265
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.