-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #493 - Upgrade Operator SDK to 1.35 #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holding this upgrade until we can assess the impact of Go 1.22 upgrade. |
ricardozanini
force-pushed
the
issue-493
branch
from
September 19, 2024 22:21
7373c55
to
35e9c80
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
force-pushed
the
issue-493
branch
from
September 23, 2024 16:52
b448130
to
075940c
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
wmedvede
reviewed
Sep 27, 2024
wmedvede
reviewed
Sep 27, 2024
wmedvede
reviewed
Sep 27, 2024
wmedvede
approved these changes
Sep 27, 2024
domhanak
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Oct 3, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
In this PR:
createdAt
that now is updated every time the bundle is generated after runningmake generate-all
non-persistence
,persistence
,cluster
, andplatform
to have quicker feedback on what failed. Also, we can disable one of these tests based on external factorscontrollers
tointernal/controller
to follow the new directory structure proposed by kubebuildertekton
dir since it's outdated and not in usegithub.com/RHsyseng/operator-utils
dependency from the main module.bddframework
must be reevaluated (cc @domhanak)Motivation for the change:
Fix #493
Follow up #538
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.