Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #493 - Upgrade Operator SDK to 1.35 #495

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Jun 20, 2024

Description of the change:
In this PR:

  • Upgrade to Go 1.22 required from the new kubebuilder version
  • Change in the check generations GHA to ignore the field createdAt that now is updated every time the bundle is generated after running make generate-all
  • Break the e2e tests into non-persistence, persistence, cluster, and platform to have quicker feedback on what failed. Also, we can disable one of these tests based on external factors
  • Moved the controllers to internal/controller to follow the new directory structure proposed by kubebuilder
  • Upgrade kubebuilder, controller-runtime, k8s api
  • Upgrade and drop outdated attributes in kustomization files
  • Adapted main.go to match the new APIs
  • Removed tekton dir since it's outdated and not in use
  • Removed the outdated github.com/RHsyseng/operator-utils dependency from the main module. bddframework must be reevaluated (cc @domhanak)

Motivation for the change:
Fix #493
Follow up #538

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini marked this pull request as ready for review June 21, 2024 18:50
@ricardozanini ricardozanini marked this pull request as draft June 21, 2024 19:10
@ricardozanini ricardozanini marked this pull request as ready for review June 21, 2024 19:30
@ricardozanini ricardozanini marked this pull request as draft June 26, 2024 19:05
@ricardozanini
Copy link
Member Author

Holding this upgrade until we can assess the impact of Go 1.22 upgrade.

@ricardozanini ricardozanini marked this pull request as ready for review September 19, 2024 22:29
@ricardozanini ricardozanini merged commit cd39bac into apache:main Sep 27, 2024
11 of 12 checks passed
@ricardozanini ricardozanini deleted the issue-493 branch September 27, 2024 16:39
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Operator SDK to 1.35
3 participants