Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix for daily dev Jenkins CI failing to build due to missing git config and hardlinked files #2861

Merged
merged 17 commits into from
Jan 20, 2025

Conversation

thiagoelg
Copy link
Member

Fixes two issues preventing the daily dev build to succeed:

  • kie-sandbox-accelerator-quarkus was creating a bare repo without the proper git config (missing user.email and user.name), as the config was not inherited from the local environment;
  • Image builds that hardlinked the local Maven repository were failing because the local Maven repository was hosted inside the container while the kie-tools files were symlinked from outside (mounted volume). This prevented the container from accessing these files and broke the build. Fixed by moving the local Maven repository to the same filesystem as the kie-tools files.

Also:

  • Removed references to the Task Console

@thiagoelg thiagoelg requested a review from tiagobento as a code owner January 16, 2025 19:41
@jomarko
Copy link
Contributor

jomarko commented Jan 17, 2025

it seems the fails is related to changes:

  
  > @kie-tools/[email protected] _build-step:setup-git-repo-content /home/runner/work/incubator-kie-tools/incubator-kie-tools/packages/kie-sandbox-accelerator-quarkus
  > export GIT_USER_EMAIL=$(git config get user.email) && export GIT_USER_NAME=$(git config get user.name) && mkdirp ./dist-dev/git-repo-content && cpy './dist/git-repo-content/**' ./dist-dev/git-repo-content && cd ./dist-dev/git-repo-content && git init --initial-branch main && git remote add repo ../git-repo-bare.git && git config set user.email $GIT_USER_EMAIL && git config set user.name $GIT_USER_NAME && git add . && git commit -m 'Single commit' && git push repo main
  
  Initialized empty Git repository in /home/runner/work/incubator-kie-tools/incubator-kie-tools/packages/kie-sandbox-accelerator-quarkus/dist-dev/git-repo-content/.git/
  error: wrong number of arguments, should be 2
   ELIFECYCLE  Command failed with exit code 129.
   ELIFECYCLE  Command failed with exit code 129.
  /home/runner/work/incubator-kie-tools/incubator-kie-tools/packages/kie-sandbox-accelerator-quarkus:
   ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kie-tools/[email protected] build:prod: `pnpm run _build && pnpm run test`
  Exit status 129

@tiagobento tiagobento merged commit 51407ee into apache:main Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants