This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Submodule Refactor Phase 1 #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-1. Pulled out mapreduce, storm and spark responders, -2. Refactored `org.apache.pirk.test.DistributedTestSuite` to handle submodules. Todo Pull out Querier, Responder Modules as mentioned on the mailing list. This will be done separately as it involved decoupling several components.
smarthi
reviewed
Dec 7, 2016
| * if you implement runDistributed test. | ||
| * @return | ||
| */ | ||
| default boolean hasDistributedTest() |
There was a problem hiding this comment.
no need of keyword default - specify nothing
smarthi
reviewed
Dec 7, 2016
| * @return The results of the QueryResponse | ||
| * @throws PIRException | ||
| */ | ||
| default public List<QueryResponseJSON> runDistributedTest(ArrayList<String> args, FileSystem fs, Querier querier, int numThreads) throws PIRException |
smarthi
reviewed
Dec 7, 2016
| String jsonBaseInputFormatString = jFormat.getClass().getName(); | ||
| SystemConfiguration.setProperty("pir.baseInputFormat", jsonBaseInputFormatString); | ||
|
|
||
| ArrayList<String> args = constructBasicArgs(); |
smarthi
reviewed
Dec 7, 2016
| @@ -59,28 +71,30 @@ | |||
| public static final int hashBitSize = 12; | |||
| public static final int paillierBitSize = 384; | |||
| public static final int certainty = 128; | |||
| public static final String STANDALONE = "standalone"; | |||
|
|
|||
| public static void testDNSHostnameQuery(ArrayList<JSONObject> dataElements, int numThreads, boolean testFalsePositive) throws Exception | |||
There was a problem hiding this comment.
change signature to pass in List<> as opposed to ArrayList<> ?
smarthi
reviewed
Dec 7, 2016
| @@ -195,14 +209,130 @@ public static void checkDNSHostnameQueryResults(List<QueryResponseJSON> results, | |||
| } | |||
| } | |||
|
|
|||
| private static ArrayList<String> constructBasicArgs() | |||
| { | |||
| ArrayList<String> args = new ArrayList<>(); | |||
There was a problem hiding this comment.
Change method signature to return List<> and LHS should be List
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to have to be broken into chunks.
Tested on a local k8s cluster and AWS. With the caveat the test jar to use is now pirk-mapreduce-0.2.0.jar or pirk-spark-0.2.0.jar.
There's several additional steps that need to happen, but I think that a lot must first be address with configuration and commandline first so I'd like to get this in and iterate the two in parallel.