Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove hard-coded credentials #694

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Oct 7, 2024

Ⅰ. Describe what this PR did

remove hard-coded credentials to pass security check #692
p.s password in e2e case will be optimized in another pr after this be merged.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 0d9d627 into apache:master Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants