optimize: support fast fail when channel disconnect after message sent for RemotingClient #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bughue
reviewed
Feb 20, 2025
| @@ -193,6 +198,7 @@ public Object sendSyncRequest(Channel channel, Object msg) throws TimeoutExcepti | |||
| return null; | |||
| } | |||
| RpcMessage rpcMessage = buildRequestMessage(msg, ProtocolConstants.MSGTYPE_RESQUEST_SYNC); | |||
| channelToRequestIds.computeIfAbsent(channel, ch -> ConcurrentHashMap.newKeySet()).add(rpcMessage.getId()); | |||
There was a problem hiding this comment.
Should the computeIfAbsent operation be extracted method? and integrated with super.sendSync? Avoid code duplication and missing calls
| @@ -222,6 +229,7 @@ public void sendAsyncRequest(Channel channel, Object msg) { | |||
| public void sendAsyncResponse(String serverAddress, RpcMessage rpcMessage, Object msg) { | |||
| RpcMessage rpcMsg = buildResponseMessage(rpcMessage, msg, ProtocolConstants.MSGTYPE_RESPONSE); | |||
| Channel channel = clientChannelManager.acquireChannel(serverAddress); | |||
| channelToRequestIds.computeIfAbsent(channel, ch -> ConcurrentHashMap.newKeySet()).add(rpcMessage.getId()); | |||
There was a problem hiding this comment.
Is fast-failure necessary for AsyncSend? Is there Future waiting in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR enhances the RemotingClient by implementing a mechanism to quickly fail pending requests when a channel disconnects after a message has been sent. The key changes include:
Ⅱ. Does this pull request fix one issue?
#7058
Ⅲ. Why don't you add test cases (unit test/integration test)?
wait a moment
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews