feature: support raft mode registry to namingserver #7114

funky-eyes · 2025-01-15T15:22:31Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov · 2025-01-16T12:22:12Z

Codecov Report

Attention: Patch coverage is 17.91667% with 197 lines in your changes missing coverage. Please review.

Project coverage is 52.18%. Comparing base (c4b9b93) to head (8ca4731).
Report is 2 commits behind head on 2.x.

Files with missing lines	Patch %	Lines
...orage/raft/sore/RaftVGroupMappingStoreManager.java	3.33%	58 Missing ⚠️
...ta/server/instance/RaftServerInstanceStrategy.java	0.00%	32 Missing ⚠️
...uster/raft/snapshot/vgroup/VGroupSnapshotFile.java	0.00%	29 Missing ⚠️
...server/instance/AbstractSeataInstanceStrategy.java	27.27%	15 Missing and 1 partial ⚠️
...ava/org/apache/seata/common/metadata/Instance.java	7.14%	13 Missing ⚠️
...erver/cluster/raft/sync/msg/RaftVGroupSyncMsg.java	0.00%	9 Missing ⚠️
...rg/apache/seata/server/filter/RaftGroupFilter.java	10.00%	9 Missing ⚠️
...ache/seata/namingserver/manager/NamingManager.java	46.66%	5 Missing and 3 partials ⚠️
...eata/namingserver/controller/NamingController.java	0.00%	7 Missing ⚠️
.../cluster/raft/execute/vgroup/VGroupAddExecute.java	25.00%	3 Missing ⚠️
... and 6 more

Additional details and impacted files

@@            Coverage Diff             @@
##                2.x    #7114    +/-   ##
==========================================
  Coverage     52.17%   52.18%            
- Complexity     6817     6850    +33     
==========================================
  Files          1154     1165    +11     
  Lines         41116    41317   +201     
  Branches       4820     4835    +15     
==========================================
+ Hits          21454    21562   +108     
- Misses        17624    17703    +79     
- Partials       2038     2052    +14

Files with missing lines	Coverage Δ
...in/java/org/apache/seata/common/metadata/Node.java	`40.00% <100.00%> (ø)`
...common/metadata/namingserver/NamingServerNode.java	`91.66% <ø> (-0.65%)`	⬇️
...ache/seata/namingserver/entity/bo/NamespaceBO.java	`59.09% <ø> (ø)`
...ot/autoconfigure/loader/SeataPropertiesLoader.java	`63.15% <ø> (ø)`
...e/properties/server/raft/ServerRaftProperties.java	`100.00% <100.00%> (ø)`
...ata/server/cluster/raft/snapshot/RaftSnapshot.java	`75.00% <ø> (ø)`
.../src/main/java/org/apache/seata/server/Server.java	`71.87% <100.00%> (ø)`
...he/seata/server/cluster/raft/RaftStateMachine.java	`44.58% <100.00%> (+32.36%)`	⬆️
...r/cluster/raft/execute/AbstractRaftMsgExecute.java	`100.00% <100.00%> (ø)`
...ata/server/cluster/raft/snapshot/RaftSnapshot.java	`82.75% <100.00%> (+0.61%)`	⬆️
... and 23 more

... and 9 files with indirect coverage changes

ggbocoder · 2025-01-17T00:42:29Z

please add signature

xingfudeshi

LGTM

xjlgod · 2025-02-17T11:55:04Z

...n/java/org/apache/seata/discovery/registry/namingserver/NamingserverRegistryServiceImpl.java

@@ -156,6 +156,9 @@ public void register(Instance instance) throws Exception {
        doRegister(instance, getNamingAddrs());
    }

+    public void doRegister(List<Instance> instance, List<String> urlList) {
+


why this method is not implemented?

This is a reserved interface because, when multi-raft is implemented, a node will have multiple instances.

xjlgod · 2025-02-17T11:57:10Z

namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java

@@ -152,7 +154,9 @@ public Result<String> createGroup(String namespace, String vGroup, String cluste
            LOGGER.error("no instance in cluster {}", clusterName);
            return new Result<>("301", "no instance in cluster" + clusterName);
        } else {
-            Node node = nodeList.get(0);
+            Node node =
+                nodeList.stream().filter(n -> n.getRole() == ClusterRole.LEADER || n.getRole() == ClusterRole.MEMBER)


why leader and memeber can be selected?

For a Raft cluster, you need to find the leader to create the group, whereas for a regular cluster, you need to find a member to create the group.

xjlgod · 2025-02-17T12:02:45Z

Maybe we can add some example to show how to config raft mode of namingserver?

funky-eyes · 2025-02-18T01:12:41Z

Maybe we can add some example to show how to config raft mode of namingserver?

Integration testing is required, but the Seata repository currently does not support it. However, you can compile the code locally and test it using a combination of client, server, and naming server.

funky-eyes added 9 commits December 14, 2024 00:04

feature: support raft mode registry to namingserver

c45ae29

feature: support raft mode registry to namingserver

f1986cb

feature: support raft mode registry to namingserver

5c45707

update

b64b2ec

Merge branch '2.x' of github.com:apache/incubator-seata into 20241213

7c9802d

opt

21f6bef

feature: support raft mode registry to namingserver

4c4db9f

feature: support raft mode registry to namingserver

e4a1a7a

merge

603555e

funky-eyes added this to the 2.4.0 milestone Jan 15, 2025

funky-eyes added module/server server module module/namingserver store: raft labels Jan 15, 2025

funky-eyes added 4 commits January 16, 2025 09:23

bugfix

0edf96c

update

5839ea5

update

5254210

update

5c7e264

funky-eyes changed the title ~~[WIP]feature: support raft mode registry to namingserver~~ feature: support raft mode registry to namingserver Jan 16, 2025

funky-eyes requested a review from ggbocoder January 16, 2025 13:34

funky-eyes and others added 2 commits January 20, 2025 11:17

Merge branch '2.x' into 20241213

4ee934e

Merge branch '2.x' into 20241213

30be558

xingfudeshi self-requested a review February 17, 2025 07:16

Merge branch '2.x' into 20241213

310ec11

xingfudeshi approved these changes Feb 17, 2025

View reviewed changes

funky-eyes added 2 commits February 17, 2025 15:37

update 2.x.md

832d904

Merge remote-tracking branch 'origin/20241213' into 20241213

5484615

xjlgod reviewed Feb 17, 2025

View reviewed changes

slievrly self-assigned this Feb 18, 2025

funky-eyes added 4 commits February 19, 2025 09:59

Merge branch '2.x' into 20241213

ca6f871

Merge branch '2.x' into 20241213

f423dea

Merge branch '2.x' into 20241213

ca68943

Merge branch '2.x' into 20241213

8ca4731

funky-eyes merged commit 3c050a2 into apache:2.x Feb 24, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support raft mode registry to namingserver #7114

feature: support raft mode registry to namingserver #7114

funky-eyes commented Jan 15, 2025

codecov bot commented Jan 16, 2025 •

edited

Loading

ggbocoder commented Jan 17, 2025

xingfudeshi left a comment

xjlgod Feb 17, 2025

funky-eyes Feb 19, 2025

xjlgod Feb 17, 2025

funky-eyes Feb 18, 2025

xjlgod commented Feb 17, 2025

funky-eyes commented Feb 18, 2025

feature: support raft mode registry to namingserver #7114

feature: support raft mode registry to namingserver #7114

Conversation

funky-eyes commented Jan 15, 2025

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov bot commented Jan 16, 2025 • edited Loading

Codecov Report

ggbocoder commented Jan 17, 2025

xingfudeshi left a comment

Choose a reason for hiding this comment

xjlgod Feb 17, 2025

Choose a reason for hiding this comment

funky-eyes Feb 19, 2025

Choose a reason for hiding this comment

xjlgod Feb 17, 2025

Choose a reason for hiding this comment

funky-eyes Feb 18, 2025

Choose a reason for hiding this comment

xjlgod commented Feb 17, 2025

funky-eyes commented Feb 18, 2025

codecov bot commented Jan 16, 2025 •

edited

Loading