feature:Transfer global timeout and branch transaction begin time #7164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiangyeyu0
changed the title
funky-eyes
reviewed
Feb 14, 2025
Comment on lines
+116
to
+117
| RootContext.setTimeout(timeout); | ||
| RootContext.setBranchBeignTime(createTime); |
There was a problem hiding this comment.
integration模块中需要传递两个值
Two values need to be passed in the integration module
slievrly
reviewed
Feb 14, 2025
| transactionTimeout = DefaultValues.DEFAULT_GLOBAL_TRANSACTION_TIMEOUT; | ||
| } | ||
| timeout = Math.max(BRANCH_EXECUTION_TIMEOUT, transactionTimeout); | ||
| branchBeginTime = RootContext.getBranchBeignTime(); |
There was a problem hiding this comment.
I don't see this branchBeginTime value being passed from the downstream service, and if it's not passed, it's no different from the previous function. Or what you're trying to say is timeout is the timeout of a branch transaction not the timeout of a global transaction?
slievrly
reviewed
Feb 14, 2025
| @@ -113,6 +113,8 @@ public void begin(int timeout, String name) throws TransactionException { | |||
| xid = transactionManager.begin(null, null, name, timeout); | |||
| status = GlobalStatus.Begin; | |||
| RootContext.bind(xid); | |||
| RootContext.setTimeout(timeout); | |||
| RootContext.setBranchBeignTime(createTime); | |||
There was a problem hiding this comment.
If I set this value here I think it is ambiguous, the time here should be the start time of the global transaction and not the begin time of the branch transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
XA模式用到的全局超时时间没有使用单独配置，需要传递全局超时时间和分支事务开始时间
The global timeout time used in the XA Mode is not configured separately, and the global timeout time and branch transaction start time need to be passed.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews