Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-823] Fix Database Tips for standalone deployment mode #826

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

liaosunny123
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Delete PostgreSQL, which is not support in inlong start script.

Modifications

Delete PostgreSQL tips.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@dockerzhang
Copy link
Contributor

MySQL is not the only choice, and we can not only limit users to using MySQL.

@liaosunny123
Copy link
Contributor Author

MySQL is not the only choice, and we can not only limit users to using MySQL.

The Tubemq start script use MYSQL as database ctl hard-codely. The other choice is that changing the run script to identify different database config.

@dockerzhang dockerzhang changed the title [INLONG-823] Fix Database Tips [INLONG-823] Fix Database Tips for standalone deployment mode Aug 14, 2023
@dockerzhang dockerzhang merged commit c191804 into apache:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Delete deployment instruction about postgresql
3 participants