Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11520][SDK] Remove DirtyServerType, use SinkType #11521

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Nov 21, 2024

Fixes #11520

Motivation

Add more enum of DirtyServerType

Modifications

Add
ICEBERG("Iceberg"), HIVE("Hive"), STAR_ROCKS("StarRocks"), KAFKA("Kafka"), PULSAR("Pulsar"), ELASTICSEARCH("Elasticsearch"), MYSQL("Mysql")

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng added this to the 2.1.0 milestone Nov 21, 2024
@vernedeng vernedeng self-assigned this Nov 21, 2024
aloyszhang
aloyszhang previously approved these changes Nov 21, 2024
fuweng11
fuweng11 previously approved these changes Nov 21, 2024
luchunliang
luchunliang previously approved these changes Nov 22, 2024
@vernedeng vernedeng changed the title [INLONG-11520][SDK] Add Common DirtyServerType [INLONG-11520][SDK] Remove DirtyServerType, use SinkType Nov 22, 2024
@aloyszhang aloyszhang merged commit 2f10b5e into apache:master Nov 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][SDK] Remove DirtyServerType, use SinkType
5 participants